phpmyadmin / docker

Docker container for phpMyAdmin
https://hub.docker.com/_/phpmyadmin
GNU General Public License v3.0
675 stars 455 forks source link

Added support for arm builds via qemu. #295

Closed TrAnn3l closed 4 years ago

TrAnn3l commented 4 years ago

Should resolve #248 Used https://www.trion.de/news/2019/10/14/docker-multi-arch-dockerhub.html and https://github.com/ckulka/docker-multi-arch-example as example. One should just need to add the new Dockerfiles to the automated build configuration in Dockerhub and the rest should work.

williamdes commented 4 years ago

@J0WI LGTM but what do you think about this PR?

williamdes commented 4 years ago

Thank you @TrAnn3l!

J0WI commented 4 years ago

I still hope that @yosifkit or @tianon will review https://github.com/docker-library/official-images/pull/7288 soon :confused:

williamdes commented 4 years ago

I still hope that @yosifkit or @tianon will review docker-library/official-images#7288 soon

Me too, I do not understand what blocs the review now, maybe they just have missed the notification Maybe I should rebase 🤔

williamdes commented 4 years ago

Could you please add some documentation on the README @TrAnn3l ?

TrAnn3l commented 4 years ago

Yes, after i finished testing. I created my own docker repo and now i'm fixing small bugs. I will post my configuration when everything works.

TrAnn3l commented 4 years ago

Ok, i am finished. I tried to make it as simple and as vanilla as possible. I also tried to keep the workflow, so one only needs to change the templates and run update.sh. In addition you should not need to change the current Docker Hub config.

You can see the working result here: https://hub.docker.com/r/trann3l/phpmyadmin This is my Docker Hub config: grafik

If you still have any questions, feel free to ask 😃

williamdes commented 4 years ago

Thanks you, I appreciate the initiative to keep things vanilla @ibennetch could you give your thoughts on this PR?

TrAnn3l commented 4 years ago

@ibennetch did you already had time to look into this PR?

J0WI commented 4 years ago

This is obsolete with https://hub.docker.com/_/phpmyadmin

TrAnn3l commented 4 years ago

Closing because of https://hub.docker.com/_/phpmyadmin.