Add PMA_QUERYHISTORYMAX config parameter

[ibennetch]

Thank you for your submission.

This is a slippery slope because I feel it's not really in the best interest to implement every configuration option as a Docker command line argument. At some point, one has to actually use a configuration file rather than passing a long string of arguments.

I would vote no on this, but wonder what others think.

[sadortun]

@ibennetch If contributors want to submit PR to improve configurability, i dont see how its a problem :) Also, you could do the same as for PMA_QUERYHISTORYDB and not mention it in the docs. But still useful if users want to adjust it.

Alternatively, you could provide a simple syntax parser that would rewrite ENV to appropriate config parameters. That way, Everything could be configurable via ENV.

[williamdes]

Thank you for your submission.

This is a slippery slope because I feel it's not really in the best interest to implement every configuration option as a Docker command line argument. At some point, one has to actually use a configuration file rather than passing a long string of arguments.

I would vote no on this, but wonder what others think.

I would say yes because the option for query history db exists. And no because of the bad idea that it is to have all our config options as hard coded ENVs

So for me I think we need to find a better solution for that and use QA_5_0 for the feature.

• support existing ENVs
• add a cool system to manage all config options

[sadortun]

Did not want to trigger a mid-life existantial crisis :) Only wanted to add my history max size param :) hehehhe

[sadortun]

@ibennetch Could you please merge this ? It doesn't prevent you to refactor the feature when you reach a decision, or postpone that decision making until someone else want to add another param 🙏 😆

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.