search

phpmyadmin / docker

Docker container for phpMyAdmin
https://hub.docker.com/_/phpmyadmin
GNU General Public License v3.0
671 stars 456 forks source link

Generate phpmyadmin-misc.ini from ENVs #320

Closed J0WI closed 3 years ago

J0WI commented 3 years ago

https://github.com/docker-library/official-images/pull/9426#issuecomment-760553422

williamdes commented 3 years ago

Hi @J0WI I added some work ontop of yours and had to revert the block you removed. The tests did prove that it is needed.

J0WI commented 3 years ago

I added some work ontop of yours and had to revert the block you removed. The tests did prove that it is needed.

The env need to be set with docker run -e. Setting them in the test script is too late for PHP.

williamdes commented 3 years ago

I added some work ontop of yours and had to revert the block you removed. The tests did prove that it is needed.

The env need to be set with docker run -e. Setting them in the test script is too late for PHP.

I added tests for the current behavior in https://github.com/phpmyadmin/docker/pull/323 It will be merged soon, feel free to let any comments

After that I will rebase your work

J0WI commented 3 years ago

Thank you!