search

phpmyadmin / docker

Docker container for phpMyAdmin
https://hub.docker.com/_/phpmyadmin
GNU General Public License v3.0
665 stars 456 forks source link

Fix GPG keyservers #341

Closed PhrozenByte closed 3 years ago

PhrozenByte commented 3 years ago

sks-keyservers.net was shut down some time ago, see https://sks-keyservers.net/ (expired cert). keys.gnupg.net is just an alias. pgp.mit.edu isn't part of the sks-keyservers.net pool, but also runs SKS and will likely suffer the same fate (like any other SKS keyserver). It is currently unavailable, but there was no take-down notice (yet). The same is true for keys.openpgp.org. I didn't remove those because we should assume that they are unavailable just temporarily. Use keys.openpgp.org as main alternative.

williamdes commented 3 years ago

Probably fixes #339

PhrozenByte commented 3 years ago

Looks like there are still some issues, it worked locally, failed on one of my servers and passed just 1/3 on GitHub Actions. Will investigate. Not ready for merge yet!

PhrozenByte commented 3 years ago

Okay, looks like this is related to https://dev.gnupg.org/T4393, also see https://keys.openpgp.org/about/faq#older-gnupg (even though I'm no PGP expert). Thus keys.openpgp.org isn't suitable as main alternative. We might wanna use keyserver.ubuntu.com instead - even though it might suffer the same fate as SKS at some time... Hopefully this gets fixed till then.

Updated the PR accordingly, now succeeds both locally and on my server. GitHub Actions pass, too. Ready for merge now.

williamdes commented 3 years ago

Thank you so much @PhrozenByte