search

phpmyadmin / docker

Docker container for phpMyAdmin
https://hub.docker.com/_/phpmyadmin
GNU General Public License v3.0
665 stars 456 forks source link

Allow a different Apache port with APACHE_PORT #369

Closed devinmatte closed 2 years ago

devinmatte commented 2 years ago

To deal with both #340 and #187, this PR allows for a new Environment variable APACHE_PORT to change the default port from 80 to something user defined. If unset, it remains using port 80

Fixes: #340

ibennetch commented 2 years ago

I don't believe we need to do this for either fpm variant, because neither of those should include Apache.

Aside from that, this looks good to me, thanks for the contribution.

devinmatte commented 2 years ago

Makes sense, I did a quick pass again, hope it's good this time

devinmatte commented 2 years ago

Okay added an apachectl configtest to the statement. It looks like CI jobs aren't getting run because I'm a first time contributor, but from my read this looks good to go. Thanks for the quick review!

devinmatte commented 2 years ago

👋 I saw there were a few new commits in master. I updated the PR against master to see if that better passes CI

williamdes commented 2 years ago

👋 I saw there were a few new commits in master. I updated the PR against master to see if that better passes CI

Thanks, I did some testing improvements to easily add a new test for this one

williamdes commented 2 years ago

I don't believe we need to do this for either fpm variant, because neither of those should include Apache.

I added 5ab888d0d484293b236fabea1ccfd062e72d902a on our update script to handle this. And updated the files: b936b8ebd118cddaab53da31266dc016d70b43fe

williamdes commented 2 years ago

wave I saw there were a few new commits in master. I updated the PR against master to see if that better passes CI

Thanks, I did some testing improvements to easily add a new test for this one

Here is the test: 3c16423f78fb73ebf26c406d68ae027bfcd18424

Thank you for this contribution @devinmatte !

williamdes commented 2 years ago

It is live on https://hub.docker.com/_/phpmyadmin !