phpmyadmin / docker

Docker container for phpMyAdmin
https://hub.docker.com/_/phpmyadmin
GNU General Public License v3.0
663 stars 453 forks source link

themes not working #398

Open StinkyTACO opened 1 year ago

StinkyTACO commented 1 year ago

i followed the info on https://docs.phpmyadmin.net/en/latest/setup.html#:~:text=Running%20with%20additional%20themes%3A

yet when i login the theme does not show up

this is my bind

image

im using the default phpmyadmin image

image
ibennetch commented 1 year ago

Which theme(s) are you trying to add? I wonder if they are compatible with your phpMyAdmin version.

StinkyTACO commented 1 year ago

Blueberry theme from the official repo version of php is 5.2.1 and theme is for 5.2

StinkyTACO commented 1 year ago

Screenshot_20230303_040914_Chrome

StinkyTACO commented 1 year ago

Screenshot_20230303_041444_Chrome

StinkyTACO commented 1 year ago

would there be any news on this yet?

williamdes commented 1 year ago

would there be any news on this yet?

Yes, I found what's wrong re-reading your post. The bind folder is wrong, see here the root: https://github.com/phpmyadmin/docker/blob/88f6d787d06c81de6a7cecdd59c1f788dd7c1217/apache/Dockerfile#L106

So it should be mounted to /var/www/html/themes/mytheme

StinkyTACO commented 1 year ago

would this not mean the documentation is wrong?

StinkyTACO commented 1 year ago

i can confirm the updated info does work

williamdes commented 1 year ago

would this not mean the documentation is wrong?

What documentation? I did not find this on the README, I will add how to mount themes

ibennetch commented 1 year ago

@williamdes We have some documentation on mounting themes at

williamdes commented 1 year ago

Thank you, that's a very strange folder for themes. Did it work someday? I need to research that

StinkyTACO commented 1 year ago

@williamdes We have some documentation on mounting themes at

Those are indeed the docs I followed.

williamdes commented 1 year ago

Seems to have been since https://github.com/phpmyadmin/docker/issues/203#issue-392540166 and here is another post where someone also used this mount path: https://github.com/phpmyadmin/docker/issues/333#issuecomment-863560724

So I found out it's since https://github.com/phpmyadmin/docker/commit/662b82d27e87722826ce4c40d2db83553e79c898 (#198)

The best is that we now update our documentation

williamdes commented 1 year ago

@tianon on the same subject as this issue, with #198 & #274 we no longer can mount sessions to /sessions I found a message of yours about that in: https://github.com/docker-library/php/issues/201#issuecomment-243233534

Can we create a new folder /sessions and change the php ini config to this folder or is it not a good change for an official image ? /cc @J0WI Currently session.save_path => no value, would be changed to session.save_path => /sessions/ What would be the best permissions for such a folder ?, for rootless compatibility ?

tianon commented 1 year ago

If this makes sense for how you want phpMyAdmin users to consume the image, it's totally fine (we just don't feel comfortable make such a general sweeping change in the php images directly).

If you want rootless compatibility, I'd suggest 1777 (matching typical /tmp permissions).

J0WI commented 1 year ago

Alternatively, you could configure an external Redis or Memcached container as PHP session handler.