phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system

MIT License

20 stars 28 forks source link

Use proper and complete JS script name while comparing to skip #130

Closed devenbansod closed 7 years ago

devenbansod commented 7 years ago

Fix #121

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

codecov-io commented 7 years ago

Codecov Report

Merging #130 into master will not change coverage. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     53.92%   53.92%           
  Complexity      212      212           
=========================================
  Files            17       17           
  Lines           942      942           
=========================================
  Hits            508      508           
  Misses          434      434

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 699e563...acd764f. Read the comment docs.

devenbansod commented 7 years ago

Thanks for the review @nijel. I have fixed the tests.

nijel commented 7 years ago

I also wonder if we should not ignore both paths as this is obviously something which has been changed on the phpMyAdmin side, so old versions will still report the old path...

devenbansod commented 7 years ago

Did you mean 'if we should ~~not~~ ignore both paths' ?

nijel commented 7 years ago

Exactly :-). Though I didn't really look when it has been changed on the phpMyAdmin site, so maybe it's too old to care...

devenbansod commented 7 years ago

I checked it just now. It was changed in https://github.com/phpmyadmin/phpmyadmin/commit/addb363cdb86bfd3f2e89aa6a9ae254641225080 in mid-2013 (changes start from Release 4.1.0-alpha1). I guess it is too old to care now ?

nijel commented 7 years ago

Thanks for looking it up, then we probably don't have to care.