Move to more phpMyAdmin-like coding style

[devenbansod]

• Move away from tab indentation to 4-spaces indentation
• Continue to move towards more phpMyAdmin-like coding style
• Continue moving Shells to phpMyAdmin-like coding style
• Continue moving Views to phpMyAdmin-like coding style

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

[codecov[bot]]

Codecov Report

Merging #131 into master will decrease coverage by 1.49%. The diff coverage is 53.65%.

@@             Coverage Diff             @@
##             master     #131     +/-   ##
===========================================
- Coverage     53.92%   52.43%   -1.5%     
  Complexity      212      212             
===========================================
  Files            17       17             
  Lines           942      967     +25     
===========================================
- Hits            508      507      -1     
- Misses          434      460     +26

[nijel]

Thanks! Are you doing the changes manually or have you configured php-cs-fixer? The latter might be better approach in the long run (though I'm not sure how much it can fix).

[devenbansod]

I currently did part-manually and part by phpcbf with original coding-standard. But I will look into configuring the tool you mentioned. If it works, then that'd be great!

[nijel]

We're already using it for motranslator, shapefile and sql-parser, so you can base on the configuration there (though that is much closer to PSR than what we use at phpMyAdmin).

[devenbansod]

Thanks for the pointer. I have made a new PR at #132 with the auto-fixes done by php-cs-fixer and have added a simiar config file to this repo (with changes to the folders to be fixed).