phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system

MIT License

19 stars 28 forks source link

Log extremely long reports and don't save them #149

Closed devenbansod closed 7 years ago

devenbansod commented 7 years ago

The text field in MySQL database holds 65535 characters maximum. If the length of submitted incident is more than that, most likely it will throw an error and truncate the data anyway.

Related to #137, #138, #140

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

nijel commented 7 years ago

Can you please check test failures?

Warning Error: array_push() expects parameter 1 to be array, null given in [/home/travis/build/phpmyadmin/error-reporting-server/tests/TestCase/Model/Table/IncidentsTableTest.php, line 370]

codecov[bot] commented 7 years ago

Codecov Report

Merging #149 into master will increase coverage by 0.51%. The diff coverage is 93.75%.

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     44.37%   44.89%   +0.51%     
- Complexity      278      283       +5     
============================================
  Files            23       23              
  Lines          1298     1312      +14     
============================================
+ Hits            576      589      +13     
- Misses          722      723       +1

nijel commented 7 years ago

Merged, thanks for your contribution!