phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system

MIT License

19 stars 28 forks source link

Add tests for shells #168

Closed devenbansod closed 7 years ago

devenbansod commented 7 years ago

This would help in increasing the code-coverage too.

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

nijel commented 7 years ago

...if the tests would work ;-)

devenbansod commented 7 years ago

Yeah. ;-) Already working on fixing them. I did not realise I have changed the Fixtures (which lead to other tests breaking). I just ran the new tests and pushed.

devenbansod commented 7 years ago

Some more changes required. Will fix them tomorrow.

codecov[bot] commented 7 years ago

Codecov Report

Merging #168 into master will increase coverage by 2.52%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
+ Coverage     47.09%   49.62%   +2.52%     
- Complexity      340      343       +3     
============================================
  Files            27       27              
  Lines          1620     1616       -4     
============================================
+ Hits            763      802      +39     
+ Misses          857      814      -43

devenbansod commented 7 years ago

Did not add the tests for Github-related shell. I will add tests for GithubController instead later (hopefully handled by mocking GithubApiComponent) which will cover that action.

nijel commented 7 years ago

Merged, thanks for your contribution!