search

phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system
MIT License
19 stars 28 forks source link

Fix #175: Broken phpMyAdmin version string stripping #176

Closed devenbansod closed 7 years ago

devenbansod commented 7 years ago

Strip pma_version correctly while creating a new report too

Fix #175 Also,

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

devenbansod commented 7 years ago

We might have to run the migration again to take care of the reports added between this period.

codecov[bot] commented 7 years ago

Codecov Report

Merging #176 into master will not change coverage. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage     82.81%   82.81%           
  Complexity      355      355           
=========================================
  Files            27       27           
  Lines          1565     1565           
=========================================
  Hits           1296     1296           
  Misses          269      269
nijel commented 7 years ago

Do you know how to rerun specific migration (without running others)?

devenbansod commented 7 years ago

I could not find a proper way easily.

So I used to do the following: In the Error reporting server's database, run: mysql > DELETE FROM phinxlog WHERE migration_name = 'FixLongPmaVersions' and then run $ bin/cake migrations migrate -t FixLongPmaVersions

nijel commented 7 years ago

Merged, thanks for your contribution!