Commits for review: Accepting & Displaying php error incidents/reports.

phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system

MIT License

20 stars 28 forks source link

Commits for review: Accepting & Displaying php error incidents/reports. #45

Closed JayNakrani closed 10 years ago

JayNakrani commented 10 years ago

Commits for review only. Would correct coding standard issues first.

coveralls commented 10 years ago

Coverage decreased (-10.01%) when pulling b590843feef85737376c502cfb3f5090bc401a9d on dhananjay92:dhananjay-gsoc-dev into 4fae475baa49ae572c7eecdcec7b37649c5b0f0a on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-9.4%) when pulling 8085593e9dd3cd608095e3079922c08544fdd9e8 on dhananjay92:dhananjay-gsoc-dev into 4fae475baa49ae572c7eecdcec7b37649c5b0f0a on phpmyadmin:master.

nijel commented 10 years ago

Maybe it would be good idea to enable travis on your repository as well to get the test results during development. Just go to travis-ci.org, register there and enable testing for your repository.

nijel commented 10 years ago

Also please try to not make our code worse, looking at the Coveralls and Scrutinizer inspection, you've lowered test coverage by 9% and introduced some code issues (code duplication and introduced unused variable).

JayNakrani commented 10 years ago

I've enabled travis-ci on my repository. I did't mean to make the code worse. I thought I'd fix all the failing tests this week and write the new test cases next week. Anyway, by the end of the next week probably those issues won't be there.

coveralls commented 10 years ago

Coverage decreased (-9.4%) when pulling 121f2ee009f7cea74fbe225b177958c0ca1068ee on dhananjay92:dhananjay-gsoc-dev into 4fae475baa49ae572c7eecdcec7b37649c5b0f0a on phpmyadmin:master.

JayNakrani commented 10 years ago

@nijel : In testCreateIncidentFromBugReport(), I could not find a solution to do initialization in Mock objects. So, I've changed the test to use actual objects. The tasks in TODO will be pushed shortly.

Right now I'm having problem in saving the closest report before case-2. See this build log for more details.

coveralls commented 10 years ago

Coverage increased (+0.15%) when pulling 5972e9bb6898b6288562229dd9a30da30a548ed9 on dhananjay92:dhananjay-gsoc-dev into 4fae475baa49ae572c7eecdcec7b37649c5b0f0a on phpmyadmin:master.

coveralls commented 10 years ago

Coverage increased (+0.15%) when pulling eae343e381479f3ca0c4c127dc92a3026b79a921 on dhananjay92:dhananjay-gsoc-dev into 4fae475baa49ae572c7eecdcec7b37649c5b0f0a on phpmyadmin:master.

scrutinizer-notifier commented 10 years ago

The inspection completed: 2 new issues, 1 updated code elements

nijel commented 10 years ago

Looks good, I've merged it and deployed on reports.phpmyadmin.net.

Please implement the missing tests, so that we get all these cases covered.

nijel commented 10 years ago

BTW: I've found another issue to fix in the code: https://github.com/phpmyadmin/error-reporting-server/issues/50