Solve Issue#31: Provide Notifications for new Error Reports & Issue#34: Mass Action on Reports - Githubissues

phpmyadmin / error-reporting-server

phpMyAdmin server side component for the error reporting system

MIT License

20 stars 28 forks source link

Solve Issue#31: Provide Notifications for new Error Reports & Issue#34: Mass Action on Reports #56

Closed JayNakrani closed 10 years ago

JayNakrani commented 10 years ago

Now with this, each developer will be notified whenever a new Error Report is generated. On each page, number of unread notifications will be displayed. Alt text

Notifications Page displays All the Pending Notifications. Alt text

TODO:

[x] Add the test cases for Notification Model & Controller.

nijel commented 10 years ago

Looks good, I will merge it once it's covered by tests.

coveralls commented 10 years ago

Coverage decreased (-3.94%) when pulling 80fb4c164d1b5541c8239a447bbc3e5703c30808 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-10.95%) when pulling 5aca8ede2ed73dc7af6dcd5b8b5e6a8d696b882b on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-10.91%) when pulling 3a5a7e221dd40bfddead0af62afb2e506631b00e on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-10.91%) when pulling 7331b570708da2c7a36c22e2e3ae90de7a596eff on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-7.64%) when pulling 9b63211534e88fdb4ed9f460e950cd089cea8b1f on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-9.64%) when pulling 42c341640fc55a193cdf5b6201a29facb06bb90b on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-9.64%) when pulling 563d5d51422459acf56d3262763aca733539a919 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-9.64%) when pulling 861842ac9618506f16ff68f538f204c9af760d11 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-9.64%) when pulling 61dc97545ce24d160be07c693f3dba7192d7ee28 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-7.1%) when pulling 2accc2c9276d8940d679a51d91c0ed66c18421e5 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-8.63%) when pulling 69eba1ea627ccae091efd36e99b9d56b4ebc8d95 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

coveralls commented 10 years ago

Coverage decreased (-14.61%) when pulling 97a3c25535a911ff7eb84b00a4bc686124814b16 on dhananjay92:gsoc-dev-final into 05a80cf752d2a6941e849c9067113749ee38d7c9 on phpmyadmin:master.

scrutinizer-notifier commented 10 years ago

The inspection completed: 2 new issues, 19 updated code elements

JayNakrani commented 10 years ago

@nijel : Why did the Test Coverage decrease?? I just added the test cases for 3 methods. Shouldn't it have increased??! :confused:

nijel commented 10 years ago

Because we don't include coverage for not at all covered files (what we IMHO should), so you've added 29.41% coverage Controller/NotificationsController.php what lowered the score...

nijel commented 10 years ago

Anyway I'm merging this now, but further improvements to testsuite are welcome :-).