search

phpmyadmin / scripts

Various scripts related to project
16 stars 19 forks source link

unsinged git tag in daily-composer #10

Open emanuelb opened 7 years ago

emanuelb commented 7 years ago

in "scripts/website/daily-composer"

    # Create tag
git tag -a -m "Composer tag for $tag" $newtag

which will create unsigned tag: https://github.com/phpmyadmin/composer/releases/tag/4.7.0

nijel commented 7 years ago

That's true - it's created automatically from the cron job, so the signing here doesn't add that much value...

emanuelb commented 7 years ago

it does (if signed by bot account) as if signing used it avoid depending on Github SSL connection (as they / MITM can't sign the repo) as it daily it better be signed by bot and not user...