phpmyadmin / scripts

Various scripts related to project

16 stars 19 forks source link

Add real name checking for Signoff and some enhancements #19

Closed williamdes closed 5 years ago

williamdes commented 5 years ago

Check that Signed-off-by is a real name
Update README.md (document events and payload types)
Removed hard coded repository name
Moved the secret to the config file
Improved code (True > true)
More changes

Tested against all our signoff lines found on the main repo.
Supports weird accents

Have a look at the comment below !

williamdes commented 5 years ago

:warning: :rescue_worker_helmet: Before you pull any changes, go to hooks/github.php and copy the value of hook_secret into a safe place. Then pull the changes and add define('GITHUB_HOOK_SECRET', 'secretHere!!'); to hooks/config.php with the value of the previously copied secret

williamdes commented 5 years ago

A preview of the message

preview

williamdes commented 5 years ago

Hello @ibennetch @nijel can you please review my changes?

Btw I tested the changes on my personal test repo.

williamdes commented 5 years ago

BTW: There is also https://github.com/apps/dco which might be used out of the box instead of implementing own code (not sure how it compares, I use this one for @WeblateOrg).

@nijel I did not find a way to add a pattern to dco bot and it generates false positives when checking the email for users using a different email or using the privacy email settings.

nijel commented 5 years ago

Okay, I just wanted to mention alternative :-).

williamdes commented 5 years ago

@ibennetch Can you please install the PR on the server ? or @nijel ?

PS: dot not forget to read the instructions https://github.com/phpmyadmin/scripts/pull/19#issuecomment-498842981

ibennetch commented 5 years ago

I have completed the installation on the server.

I've even tested it with https://github.com/phpmyadmin/phpmyadmin/pull/15340 and it looks great. Thanks.

williamdes commented 5 years ago

Thanks for installing the PR :) You will new see checked green on webhooks list on each repo since I implemented 🏓 ping requests (github zen) instead of red cross for 500 errors