phpmyadmin / scripts

Various scripts related to project
15 stars 19 forks source link

Is the SOB bot broken ? and use token requests #25

Closed williamdes closed 3 years ago

williamdes commented 4 years ago

We should use tokens and not credentials to allow our bots to have 2FA some day (or bots from other people)

https://github.com/phpmyadmin/scripts/blob/38c6067929dfff57dc0a5fb5c79fbbf90c8e810b/hooks/lib/github.php#L13

williamdes commented 4 years ago

cc @ibennetch The bot was not triggered for https://github.com/phpmyadmin/phpmyadmin/pull/16159 that has a non valid SOB line (for a human it is, ok for this time)