phpmyadmin / scripts

Various scripts related to project
16 stars 19 forks source link

Add PO update script for phpmyadmin repo #44

Closed MauricioFauth closed 3 years ago

MauricioFauth commented 3 years ago

I created a script to automatically update the PO files, instead of manually running the ./scripts/update-po script every time.

I think automatically updating the master branch is enough, since usually there is not much changes in QA branches.

MauricioFauth commented 3 years ago

Nice! At what schedule should we make it run?

Once or twice a week is good enough.

williamdes commented 3 years ago

Nice! At what schedule should we make it run?

Once or twice a week is good enough.

I would say once a month ? phpmyadmin/phpmyadmin#16529 is a good reason for this, users that use Git have a lot of diffs to checkout and new contributors too Maybe that will avoid frequent big diffs in the repo

MauricioFauth commented 3 years ago

I would say once a month ?

I think that will create bigger diffs than running more frequently.

phpmyadmin/phpmyadmin#16529 is a good reason for this, users that use Git have a lot of diffs to checkout and new contributors too Maybe that will avoid frequent big diffs in the repo

There is not much we can do about that. phpMyAdmin is a really big repository with 120k+ commits. Any repository that big will be slow to clone.

williamdes commented 3 years ago

I would say once a month ?

I think that will create bigger diffs than running more frequently.

phpmyadmin/phpmyadmin#16529 is a good reason for this, users that use Git have a lot of diffs to checkout and new contributors too Maybe that will avoid frequent big diffs in the repo

There is not much we can do about that. phpMyAdmin is a really big repository with 120k+ commits. Any repository that big will be slow to clone.

Yup, okay Once a week is okay for me Maybe Isaac would have some advice on what user should run this cron ? Or maybe @mauriciofauth you could build a GitHub actions worflow for that using the cron feature ?

MauricioFauth commented 3 years ago

what user should run this cron ?

localized_docs updates are done by the @phpmyadmin-bot.

williamdes commented 3 years ago

what user should run this cron ?

localized_docs updates are done by the @phpmyadmin-bot.

Yeah, I meant on the server :p Using actions would be a nice way to run the script

MauricioFauth commented 3 years ago

Closed in favor of https://github.com/phpmyadmin/phpmyadmin/pull/16955.