search

phpmyadmin / sql-parser

A validating SQL lexer and parser with a focus on MySQL dialect.
https://packagist.org/packages/phpmyadmin/sql-parser
GNU General Public License v2.0
442 stars 102 forks source link

Fix #556 - Implementing and refactoring the KILL statement parser #565

Closed iifawzi closed 3 months ago

iifawzi commented 4 months ago

Hey!

This PR extends support of KILL statements. completing #557 and fixing 556

Fixes #556

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.81%. Comparing base (edc7db8) to head (afe9173). Report is 12 commits behind head on 5.10.x.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 5.10.x #565 +/- ## ============================================ + Coverage 96.79% 96.81% +0.02% - Complexity 2259 2294 +35 ============================================ Files 69 70 +1 Lines 5174 5248 +74 ============================================ + Hits 5008 5081 +73 - Misses 166 167 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kamil-tekiela commented 4 months ago

DS_Store are MacOS files so they are not relevant to this project. They should not be ignored at all. You can ignore them locally on your machine.

iifawzi commented 4 months ago

it's easier for future contributors to have it ignored by the repo as we do with .idea, vim, and backup files.

williamdes commented 4 months ago

DS_Store are MacOS files so they are not relevant to this project. They should not be ignored at all. You can ignore them locally on your machine.

I checked, and yes I think the actual consensus is to remove them locally. We do not have it in any repo.

Ref: https://github.com/phpmyadmin/phpmyadmin/issues/15903#issuecomment-581431150 Can you remove the commit ?