search

phpmyadmin / sql-parser

A validating SQL lexer and parser with a focus on MySQL dialect.
https://packagist.org/packages/phpmyadmin/sql-parser
GNU General Public License v2.0
442 stars 102 forks source link

Feature/from 5 9 define context keywords relying on token constants #570

Closed niconoe- closed 3 months ago

niconoe- commented 3 months ago

Same as #569 but from 5.9.x branch.

niconoe- commented 3 months ago

@williamdes / @kamil-tekiela Are you OK with these changes? I'm having issues with PHPStan about files I didn't change, and with Psalm on Generated contextes but this will be fixed on future versions (with PHP 8.2 minimum) I guess. Benchmark issues, I don't get it too…

niconoe- commented 3 months ago

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks :slightly_smiling_face:

williamdes commented 3 months ago

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks 🙂

For me this is all good, only awaiting a review from @MauricioFauth