search

phpmyadmin / sql-parser

A validating SQL lexer and parser with a focus on MySQL dialect.
https://packagist.org/packages/phpmyadmin/sql-parser
GNU General Public License v2.0
442 stars 102 forks source link

Fix #434 - No error when using `UPDATE ... SET` #577

Closed niconoe- closed 3 months ago

niconoe- commented 3 months ago

Fixes #434

@williamdes / @iifawzi / @MauricioFauth / @liviuconcioiu

This should also be fixed in 5.10.x and master. How do you want me to proceed to perform this?

MauricioFauth commented 3 months ago

Could you please target 5.10.x instead of 5.9.x? Thanks!

niconoe- commented 3 months ago

Could you please target 5.10.x instead of 5.9.x? Thanks!

Done, but the bug will remain in 5.9.x after the merge…

Or do you plan to release a 5.10.0 soon ? :innocent: :yum:

niconoe- commented 3 months ago

I updated the fix because it caused failures in SET operations out of an update statement context (like SET NAMES …).

Now, that's ok :smiley: . (except a linter in PHP 7.4 which is out of the scope of this PR :shrug: ).