search

phpmyadmin / themes

Third party phpMyAdmin themes
https://www.phpmyadmin.net/themes/
202 stars 154 forks source link

New update BooDark v1.1.0 - pma 5.2 #102

Closed adorade closed 1 year ago

adorade commented 1 year ago

Changes

Fixes: #100

adorade commented 1 year ago

Thanks for appreciation!

adorade commented 1 year ago

Why does the review take so long?

williamdes commented 1 year ago

Why does the review take so long?

Well, actually releases rely on @ibennetch that's why it's still pending :/

williamdes commented 1 year ago

Hi @adorade

I just found out this bug On drop tables, the query is not readable due to the text color.

image

Is it fixed now ?

adorade commented 1 year ago

@williamdes I think so, but I'll double check later to be sure

adorade commented 1 year ago

Solved in BooDark v1.1.0: https://github.com/adorade/boodark/issues/35 What version of the BooDark theme are you using?

adorade commented 1 year ago

@ibennetch can you review this PR? Thank you!

williamdes commented 1 year ago

Solved in BooDark v1.1.0: adorade/boodark#35 What version of the BooDark theme are you using?

Probably the (old) latest version :/ Sorry about that, I will update my setup with the version in this PR

ibennetch commented 1 year ago

I think the way to handle this is for me to create a different release for each color scheme.

For phpMyAdmin version 6.0, we will have a "colorModes" option (you can see it best in 'metro' theme, https://github.com/phpmyadmin/phpmyadmin/blob/daa252ba42cca3ce8b37062e6916db923a91c9bb/public/themes/metro/theme.json#L8 and throughout the theme), which may be very helpful to you.

ibennetch commented 1 year ago

This theme looks great! I love the color options. I've published the releases to our theme page.

adorade commented 1 year ago

For phpMyAdmin version 6.0, we will have a "colorModes" option (you can see it best in 'metro' theme, https://github.com/phpmyadmin/phpmyadmin/blob/daa252ba42cca3ce8b37062e6916db923a91c9bb/public/themes/metro/theme.json#L8 and throughout the theme), which may be very helpful to you.

@ibennetch I have already implemented colorModes in BooDark v2 for pma v6, I will review the latest changes in pma source code next week and I will open an issue or PR only for testing purpose.