search

phpmyadmin / themes

Third party phpMyAdmin themes
https://www.phpmyadmin.net/themes/
203 stars 153 forks source link

New 5.1/5.2 theme fistu #64

Closed khadkamhn closed 1 year ago

khadkamhn commented 3 years ago

Can you please review this theme?

williamdes commented 3 years ago

Hi @khadkamhn What license are the fonts/* files ?

khadkamhn commented 3 years ago

@williamdes

Please check the above url. https://github.com/feathericons/feather/blob/master/LICENSE

williamdes commented 3 years ago

@williamdes

Please check the above url. https://github.com/feathericons/feather/blob/master/LICENSE

Perfect, would you mind copying the license file in the folder please?

Also it would be nice to only have scss files and not compiled css files

cc @mauriciofauth

khadkamhn commented 3 years ago

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

AppCarde commented 2 years ago

How to upload a theme 5.2 in dark mode?

williamdes commented 2 years ago

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

Thank you ! Wow near one year already past..

@mauriciofauth could you help with the review ?

williamdes commented 2 years ago

I just tried this theme and it needs some fixing to work on 5.1 and a bit more for 5.2 Apart from that it really looks good and cool ! The icons are very nice

williamdes commented 1 year ago

I am keeping this on hold until I review it. Thank you for the recent changes ! You can git reset --hard on your remote master branch, I force pushed it to clean up the history and fix this PR

williamdes commented 1 year ago

On 5.2 I found this bug

image

williamdes commented 1 year ago

I force pushed your branch and updated your css files, also updated bootstrap.scss You can hard reset onto the master branch and create a new branch for your fixes for 5.2 :)