search

phpmyadmin / themes

Third party phpMyAdmin themes
https://www.phpmyadmin.net/themes/
200 stars 154 forks source link

BooDark - errors, bugs, features #92

Closed adorade closed 1 year ago

adorade commented 1 year ago

Hi @ibennetch @williamdes

The BooDark theme is a new theme, currently under development, and I'm happy to get feedback from those who are already using it. Personally, while using it, I discover errors and bugs but also things that I would like to improve. Being a "dark-mode" theme, it's much more pleasing to the eyes.

In the next 2 weeks I plan to release a new, much improved version that will be much more stable. So if you find bugs, errors or want some improvements, please feel free to open a new issue, it would help me a lot. Thank you! :wink:

williamdes commented 1 year ago

image I think this is confusion because the un-selected button is not clearly a button. Maybe borders would help

adorade commented 1 year ago

I'm a little confused. This is how it looks to me, BooDark v1.0.1. Please give me more information.

Normal: button-choose-file-server

Focused: button-choose-file-focus-server

I assume it's about "Choose File", which should stand out better

adorade commented 1 year ago

Tested in Chrome, new style, extend '.btn-dark' or '.btn-outline-info`. I prefer option 1, dark button.

button-choose-file-server-opt-1 button-choose-file-server-opt-2

williamdes commented 1 year ago

The dark button is cool, no need to change it. You are missing https://docs.phpmyadmin.net/en/latest/config.html#cfg_UploadDir or https://docs.phpmyadmin.net/en/latest/config.html#cfg_SaveDir to enable more features

adorade commented 1 year ago

I understand. I think I should update my config.inc.php with the default settings so I can test other things better. What are you saying now?

button-select-file-to-import

button-select-file-to-import-2

I also put borders but it doesn't look so good:

button-select-file-to-import-border

I prefer w/out borders. Like in Bootstrap theme.

williamdes commented 1 year ago

I also put borders but it doesn't look so good:

I agree, maybe a border around the two buttons to make it clear there is two modes ?

adorade commented 1 year ago

I think you mean nav-pills to act like btn-group. Like this, w/out borders but with dark background, better solution:

nav-pills-group-1 nav-pills-group-2

williamdes commented 1 year ago

Wow, I like it. It really looks nice !

adorade commented 1 year ago

Included in next release 😉

williamdes commented 1 year ago

Was this fixed by #94 ?

adorade commented 1 year ago

BooDark theme appears in https://demo.phpmyadmin.net/STABLE/ ❤️ not in https://demo.phpmyadmin.net/QA_5_2/ 😢 (logged in as root with empty password).

My intention is to maintain the theme, to keep up with the changes made for version 5.2.x 🚀 and to prepare it for the future version 5.3.0. 🚀 🚀 🚀

williamdes commented 1 year ago

I added this on my todo list, there is something wrong with the demo server build script

adorade commented 1 year ago

Thanks... when you have time. Also, new release v1.0.2 has not yet been uploaded to https://www.phpmyadmin.net/themes/

williamdes commented 1 year ago

I made a bunch of fixes to the demo update script, it should be okay now

williamdes commented 1 year ago

Here is a new bug (white body): image

adorade commented 1 year ago

@williamdes Thank you for reporting this. I will check as soon as possible. It seems that `#table_name_col_no_outer' should have some space around it.

create_table

... and "Create table form" should have the same background-color

create_table_form_1 create_table_form_2

williamdes commented 1 year ago

I found another one for you image

I think the background is too black and this made me think that it was a bug (the first second when there was no data).

adorade commented 1 year ago

@williamdes Fixed in next release. 😉 (#98)

williamdes commented 1 year ago

@williamdes Fixed in next release. wink (#98)

Awesome ! Can you create a new issue to track the progress of this extension to be published on the website ?