phpmyadmin / website

phpMyAdmin's website generator
https://www.phpmyadmin.net/
46 stars 100 forks source link

Misaligned close button in modal on downloads page #150

Closed winstonDeGreef closed 1 year ago

winstonDeGreef commented 2 years ago

In the modal that opens on the phpymadmin download page when clicking on a download link, the close button is misaligned.

browser info: Version 98.0.4758.102 (Official Build) (64-bit) running on ubuntu

Frame 1

williamdes commented 2 years ago

Hi @mauriciofauth Could you please have a look ?

MauricioFauth commented 2 years ago

Could you please have a look ?

Sure thing.

vimalMK commented 2 years ago

Hi @williamdes @MauricioFauth Can I have a look at it?

Does something like this works

image

ibennetch commented 2 years ago

@vimalMK that styling and spacing looks good. I think a close button belongs on the right side, though, could you move it as part of your fix?

winstonDeGreef commented 2 years ago

That button feels as if it is too close to the top. (Also, float: right or float: lef in css makes the browser handle the flow of text around the element)

vimalMK commented 2 years ago

@vimalMK that styling and spacing looks good. I think a close button belongs on the right side, though, could you move it as part of your fix?

I should be able to do that.

That button feels as if it is too close to the top. (Also, float: right or float: lef in css makes the browser handle the flow of text around the element)

Using float make sense and might as well use some padding around button for position.

Thanks you. Will get to the PR soon.

vimalMK commented 2 years ago

PR added with changes #152

williamdes commented 1 year ago

It should be okay now