search

phpol / phpol

8 stars 3 forks source link

Namespace definition #1

Closed naroga closed 7 years ago

naroga commented 7 years ago

This is a reserved thread so we can discuss which namespace to use.

joubertredrat commented 7 years ago

For me is better Ol\String, all namespace need to have letter as upcase.

naroga commented 7 years ago

IMO, OL (all caps) works better to make it clear it's an acronym.

joubertredrat commented 7 years ago

IMO, OL (all caps) works better to make it clear it's an acronym.

This is good too, but all downcase isn't good as @lucasmezencio want ol.

joubertredrat commented 7 years ago

@hernandev will need to fix this on composer after define this.

lucasmezencio commented 7 years ago

@joubertredrat I didn't!

hernandev commented 7 years ago

@joubertredrat and everyone.

OL should be all caps since it's not a word but an acronym.

since each letter stands for a word.

It's CIA not Cia or NSA not Nsa

joubertredrat commented 7 years ago

Let's make this.

:one: =Ol\String :two: =OL\String :three: =ol\String

@hernandev @naroga @lucasmezencio @marcusagm vote on this comment.

marcusagm commented 7 years ago

I agree! OL all caps

hernandev commented 7 years ago

2 - OL All caps

joubertredrat commented 7 years ago

2 - OL All caps

pedrommone commented 7 years ago

2 - I agree with OL, its cleaner.

DennyLoko commented 7 years ago

2 - OL All caps

lucasmezencio commented 7 years ago

2 - OL All caps

lucasmezencio commented 7 years ago

Issue closed. Voting closed. Thanks guys.