Bump allowable maximum versions for sami & php-parser

phpowermove / php-code-generator

PHP code generator library

https://php-code-generator.readthedocs.org

Apache License 2.0

147 stars 43 forks source link

Bump allowable maximum versions for sami & php-parser #46

Closed erayd closed 7 years ago

erayd commented 7 years ago

What

Add ~3 to the allowed versions for nikic/php-parser (necessary)
Add ~4 to the allowed versions list for sami/sami (nice-to-have)

Why

Because using this library in a project that also requires sami ~4 is currently impossible, as sami ~4 requires php-parser ~3.

erayd commented 7 years ago

Travis no longer supports HHVM tests on the default 'precise' test platform. All other CI tests pass correctly.

erayd commented 7 years ago

Master branch is updated to build on 'trusty', but PHPUnit 6.2.2 does not support the version of HHVM on that platform (reports as PHP-5.6.99-hhvm), so tests are unable to run at all for HHVM (see the HHVM build log).

All CI tests that are executable on Travis pass correctly.

gossi commented 7 years ago

I just had a quick look into travis docs for hhvm. I give it a quick try, which didn't work ;). Though I have more libs to update. Will do this in early july, update them all and also release new version for this.

erayd commented 7 years ago

Awesome, thanks :-).

gossi commented 7 years ago

fixed in 661fa282410d850c615e5f265a81663d29b38c10

gossi commented 7 years ago

version 0.5 is out.

erayd commented 7 years ago

Thanks! :-)