search

phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 429 forks source link

Remove Monolog v3 as it is not currently compatible with GrumPHP #1021

Closed sippsolutions closed 2 years ago

sippsolutions commented 2 years ago

Fixes #1020

veewee commented 2 years ago

Thanks for reporting. Would you mind fixing the error for both v2 and v3 instead of removing v3?

sippsolutions commented 2 years ago

@veewee it seems Monolog v3 only got integrated with no visible reason or testing. This PR fixes the issue so users can use grumphp again with the newest version. If anyone got more time than me feel free to fix the issue with v3 :)

soulcodex commented 2 years ago

The error is from monolog library or is dependency error of grumphp? Maybe is a good idea open PR in monolog repository or look some workaround because if a project install Monolog v3 and has activated git task project will broke a lot CI/CD pipelines in many projects.

@sippsolutions @veewee

veewee commented 2 years ago

Closing this one, since composer will just fall back to the current version and still install monolog v3. This is not a good solution - you might as well just lock the previous version instead.