phpro / grumphp

A PHP code-quality tool

MIT License

4.11k stars 430 forks source link

Arkitect support #1038

Closed JTubex closed 1 year ago

JTubex commented 1 year ago

Q	A
Branch	master for features and deprecations
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Documented?	yes
Fixed tickets	#1036

New Task Checklist:

[x] Are the dependencies added to the composer.json suggestions?
[x] Is the doc/tasks.md file updated?
[x] Are the task parameters documented?
[x] Is the task registered in the tasks.yml file?
[x] Does the task contains phpunit tests?
[ ] Is the configuration having logical allowed types?
[x] Does the task run in the correct context?
[x] Is the run() method readable?
[x] Is the run() method using the configuration correctly?
[x] Are all CI services returning green?

veewee commented 1 year ago

Nice! Thanks.

JTubex commented 1 year ago

I was checking the MR again and forgot to update the default value in the docs 🙈

Created #1039