search

phpro / grumphp

A PHP code-quality tool
MIT License
4.11k stars 429 forks source link

Add allow-list config option to securitychecker_enlightn #1052

Open peterjaap opened 1 year ago

peterjaap commented 1 year ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets https://github.com/phpro/grumphp/discussions/1037

Add allow-list config option to be able to ignore given vulns, see https://github.com/enlightn/security-checker#allow-vulnerabilities

peterjaap commented 1 year ago

Needs some work, I'll get back to this.

peterjaap commented 1 year ago

@veewee done! :partying_face:

veewee commented 9 months ago

@peterjaap It's a nice feature... Care to finish up this PR? :)

peterjaap commented 9 months ago

@veewee sure, but I've asked you some questions in the comments

veewee commented 9 months ago

@veewee sure, but I've asked you some questions in the comments

@peterjaap Is it possible you made those comments as part of a code review but did not submit those comments? I am not seeing any.

peterjaap commented 9 months ago

@veewee woops, you're right :see_no_evil: Almost a year ago, lol.