search

phpro / grumphp

A PHP code-quality tool
MIT License
4.15k stars 434 forks source link

Support PHP 82 - Drop PHP 74 #1053

Closed veewee closed 2 years ago

veewee commented 2 years ago
Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

Following the PHP cycle: https://www.php.net/supported-versions.php

Following the Symfony cycle: https://symfony.com/releases

pelletiermaxime commented 2 years ago

Is there a reason to drop support for 7.4 in a minor release ? The package uses symfony 5.4 components and in the linked page we see that symfony 5.4 supports php >= 7.2.5, so I am not sure why 7.4 would be dropped in grumphp. The supported php versions is irrelevant as most distribution will keep supporting 7.4 for 10+ years.

veewee commented 2 years ago

Hello @pelletiermaxime,

PHP 74 will not be supported anymore by PHP internals in 3 days: https://www.php.net/supported-versions.php

Both Symfon, PHP Internals and most distributions have a major amount of people working on that. We currently don't have room for dealing with more than 3 active PHP versions and 2 major Symfony versions. At PHPro, we always strive to keep our PHP versions up-to-date and don't see the benifit in supporting software that isn't supported by the dependant software's authors anymore.

You can use an older version of GrumPHP on 74 for the next 10+ years, but I am not actively planning on maintaining that version. Don't worry: GrumPHP is very stable at this moment. You only won't receive any new goods on PHP 74 anymore.

Since nothing has changed in the API of GrumPHP, this is not a breaking change and a minor release is OK. You just won't be able to fetch the latest version because of your individual PHP constraints.