search

phpro / grumphp

A PHP code-quality tool
MIT License
4.11k stars 429 forks source link

Fix #912: Ignore deleted files in file_size task #1055

Open jmdelehaye opened 1 year ago

jmdelehaye commented 1 year ago
Q A
Branch master for features and deprecations
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets #912

This PR :

NB: This dev was made on v1.5.1, due to my local PHP version.

veewee commented 1 year ago

Hello,

Thanks for the PR! I am a bit confused though:

https://github.com/phpro/grumphp/blob/d855145f4f7121c96bdd72866e9788abce7024d5/src/Locator/ChangedFiles.php#L56-L70

The files should never contain any deleted files to begin with. Can you tell me more on how I can reproduce the issue?