phpro / grumphp

A PHP code-quality tool

MIT License

4.11k stars 429 forks source link

[Docs] Fix invalid Rector install command #1057

Closed IonBazan closed 1 year ago

IonBazan commented 1 year ago

Q	A
Branch	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Documented?	yes
Fixed tickets	-

Rector package name is rector/rector: https://packagist.org/packages/rector/rector

New Task Checklist:

[ ] Are the dependencies added to the composer.json suggestions?
[ ] Is the doc/tasks.md file updated?
[ ] Are the task parameters documented?
[ ] Is the task registered in the tasks.yml file?
[ ] Does the task contains phpunit tests?
[ ] Is the configuration having logical allowed types?
[ ] Does the task run in the correct context?
[ ] Is the run() method readable?
[ ] Is the run() method using the configuration correctly?
[ ] Are all CI services returning green?

veewee commented 1 year ago

Woops, thanks for noticing!

IonBazan commented 1 year ago

@veewee sorry I missed that composer.json refers to that too: https://github.com/phpro/grumphp/blob/d855145f4f7121c96bdd72866e9788abce7024d5/composer.json#L78 Maybe you can fix that manually?

veewee commented 1 year ago

Fixed it! Thanks for pointing it out.