search

phpro / grumphp

A PHP code-quality tool
MIT License
4.15k stars 431 forks source link

Fixed Windows compatibility #107

Closed llaville closed 8 years ago

llaville commented 8 years ago

While I run tests on my future new task proposal for php_blacklist commented in issue #53, I found an error in RegisteredFiles Locator.

See https://github.com/phpro/grumphp/blob/master/src/GrumPHP/Locator/RegisteredFiles.php#L35

PHP_EOL must be replaced by "\n"

llaville commented 8 years ago

See logger helper proposed by PR https://github.com/phpro/grumphp/pull/111

veewee commented 8 years ago

Fixed in #112. I also added Windows CI to make sure we detect this kind of issues earlier.