phpro / grumphp

A PHP code-quality tool
MIT License
4.11k stars 429 forks source link

Normalize yaml code blocks in doc #1071

Closed jreklund closed 1 year ago

jreklund commented 1 year ago
Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #1069

One thing I'm not 100% certain about are my phpcsfixer2 into phpcsfixer rename. I think that was a typo so I corrected it.

veewee commented 1 year ago

Looks good! I've got one question about the editor config.

One thing I'm not 100% certain about are my phpcsfixer2 into phpcsfixer rename. I think that was a typo so I corrected it.

That is correct! Previously we had both phpcsfixer(1) and phpcsfixer2 tasks. Now that v1 is deprecated, we removed it and renamed it to phpcsfixer.

veewee commented 1 year ago

Thanks @jreklund . Looks good to me! Or can you think of anything else that needs to be done in thisPR?

jreklund commented 1 year ago

I'm finished on my end. Better to merge it so that other features don't end up with merge conflict for holding this one.

veewee commented 1 year ago

Thanks again! :)