Closed jreklund closed 1 year ago
Looks good! I've got one question about the editor config.
One thing I'm not 100% certain about are my phpcsfixer2 into phpcsfixer rename. I think that was a typo so I corrected it.
That is correct! Previously we had both phpcsfixer(1) and phpcsfixer2 tasks. Now that v1 is deprecated, we removed it and renamed it to phpcsfixer.
Thanks @jreklund . Looks good to me! Or can you think of anything else that needs to be done in thisPR?
I'm finished on my end. Better to merge it so that other features don't end up with merge conflict for holding this one.
Thanks again! :)
yaml
indentations to 4 spacesyml
toyaml
code blocksgrumphp.yml
to code blocks starting withgrumphp:
grumphp.yml
from some code blocks to reflect the rest of the doc:
to parameters docOne thing I'm not 100% certain about are my
phpcsfixer2
intophpcsfixer
rename. I think that was a typo so I corrected it.