phpro / grumphp

A PHP code-quality tool
MIT License
4.11k stars 429 forks source link

Prints error message when rejecting commit #1108

Closed EwenQuim closed 9 months ago

EwenQuim commented 9 months ago
Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? what is BC?
Deprecations? no
Documented? no
Fixed tickets #1106

Fixes the issue described in #1106

New Task Checklist:

veewee commented 9 months ago

Thanks @EwenQuim It seems like the functional e2e tests pass in this pr. The code looks good, but you need to alter the phpunit testcases for this task to match the new error messages.

EwenQuim commented 9 months ago

Hi again @veewee .

It seems that the only difference between my changes and the existing version is that the newLines are replaced by a visible \n. Do you have any idea of what I did wrong ?

Also, I messed up amending my commits. Don't worry, it will be fixed when I'll be able to understand how to fix the tests. The PR should be OK after this, I think.

veewee commented 9 months ago

Thanks again! :)

EwenQuim commented 9 months ago

Thank you too!

When do you think a release will be made ?

veewee commented 9 months ago

Most likely at the end of the month.