search

phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 430 forks source link

Validate Git branch naming convention #328

Closed ademarco closed 7 years ago

ademarco commented 7 years ago
Q A
Version 0.11.3
Bug? no
New feature? yes
Question? yes
Documentation? no
Related tickets

In my organisation we need to enforce specific Git branch naming conventions so I was wondering if this is something GrumPHP could take care of.

I've been sneaking around the code and it looks like we could leverage the \Gitonomy\Git\Reference\Branch class to gather information about the current branch and validate it using regular expressions, like the commit message task currently does.

Would this be something interesting for GrumPHP? In case it would be we could dedicate some time to it.

drupol commented 7 years ago

👍

netlooker commented 7 years ago

👍

veewee commented 7 years ago

👍 That would be a nice addition. Feel free to implement.

ademarco commented 7 years ago

Ok PR is ready for review!

veewee commented 7 years ago

Implemented in #329.