phpro / grumphp

A PHP code-quality tool
MIT License
4.15k stars 430 forks source link

Composer v2 compatibility #768

Closed JeppeKnockaert closed 4 years ago

JeppeKnockaert commented 4 years ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #756

This pull request adds support for Composer v2. I've also added the version of composer to the test matrix, so both versions are tested.

veewee commented 4 years ago

Thanks for the PR! It looks really nice.

The error is related to a broken openssl on appveyor, will have to take a look at why it fails before I merge it in.

JeppeKnockaert commented 4 years ago

Thank you @veewee. It seems every recent PR has this issue. I believe it is linked to this PHP issue, which was fixed in 7.4.6RC1 according to the comments in that issue (https://bugs.php.net/bug.php?id=79589).

veewee commented 4 years ago

yeah .. maybe best to hardcode it to a previous 7.4 version for now?

veewee commented 4 years ago

Thanks again!