Closed Szadeck closed 4 years ago
Found the answer, this is not a bug anymore but a documentation issue:
Was running grump with "php ./vendor/bin/grumphp run" as explained in "https://github.com/phpro/grumphp/blob/master/doc/commands.md#run" and it never worked but on a random commit grump trigerred himself with the git hook and eslint finally appeared.
I checked the hook and found that it wasn't running this exec, it was runnning "vendor/phpro/grumphp-shim/grumphp". So i tried and it works perfectly.
I have an issue using ESLint as a normal task with grumphp. I reproduced the documentation steps with the whitelist parameter set to : - /src\/(.*)/ I have a file.js in rootDir/src/ and i'm launching "php vendor/bin/grumphp run" to test. My ESLint step is simply skiped as follow:
Running task 1/4: phpcs... ✔ Running task 2/4: phpmd... ✔ Running task 3/4: eslint... Running task 4/4: phpunit... ✔
But when i run ESlint as standalone: _"nodemodules/.bin/eslint -c conf/eslintrc.yml src"
It works perfectly.
Even when i try to leave the whitelist blank, which is suppose to run every file that match my "triggered_by" parameter in my rootdir, as i read the doc "This is a list of regex patterns that will filter files to validate. With this option you can skip files like tests. This option is used in relation with the parameter triggeredby." . But here again i got my task skipped the same way. The example given is not working too if i didn't miss something. Reading the source code :
Maybe the issue come from getFiles which brings me 0 files and got skipped from the check.
My configuration
Steps to reproduce:
Result: