Closed ghost closed 4 years ago
PS: I realize that people could still want to use ^3.0 versions. But even the 3.2.0 version is broken if you use the correct namespace for the class. Still think it's best to go >=4 without making it too complicated for inexperienced users.
Makes sense to do it like this. You can always use an older version and change the default namespace if you want to.
Thanks!
With the default settings for the twigcs task in Grumphp we require the >=4.0 versions:
https://github.com/phpro/grumphp/blob/b8354000dc6e177ab1e77c06817876f11bb6c879/src/Task/TwigCs.php#L19-L25
Earlier version like ^3.0 have a different namespace:
https://github.com/friendsoftwig/twigcs/blob/7c4bc76dad8d851045b9eeab4979a240550f8300/src/Ruleset/Official.php#L3
For that I think it's best that we change the documentation line to require the >=4 version of this package.