search

phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 430 forks source link

Made Ecs task fixable #828

Closed krzysztof-ciszewski closed 4 years ago

krzysztof-ciszewski commented 4 years ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes

The Ecs task now returns a FixableTaskResult allowing it to work with the fixer parameter.

oallain commented 4 years ago

Hello

A year ago @veewee told me, grumphp don't fix anything, see https://github.com/phpro/grumphp/pull/625#discussion_r277349551 The question regarding this point is no longer in the FAQ, it is still relevant ?

veewee commented 4 years ago

@oallain we added a fixer component to grumphp, that works in a consistent and safe way. so that faq item is no longer relevant.

Will try to take a deeper look at this PR soon.

oallain commented 4 years ago

@veewee, thnaks for answer, good news ! So i'll review this PR :heart_eyes:

veewee commented 4 years ago

Thanks!