phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 430 forks source link

Implement refactored formatter options for Deptrac >= v0.9.0 #841

Closed jerowork closed 3 years ago

jerowork commented 3 years ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Documented? yes
Fixed tickets none

Description

Deptrac has updated formatter options in v0.9.0. They enabled new formatters (e.g. baseline, table) and refactored existing formatters (e.g. Graphviz). This means that the previous options are not working anymore. New options are introduced for existing formatters.

This PR adds all new formatters with its new options to the DeptracTask.

See commit descriptions for further information.

Resources

jerowork commented 3 years ago

I'dd suggest only adding the new types without providing BC grumphp configuration.

What do you think?

It certainly makes it easier indeed. As it's below v1.0, I agree with you. I will remove the pre-v0.9 options completely 👍

veewee commented 3 years ago

Thanks for changing and adding the options!