Closed dhaarbrink closed 3 years ago
Thanks for the PR! It makes sense to do it like this.
Can you also add a unit test covering this case? There is already a test for when there are files available, so it should be a small addition: https://github.com/phpro/grumphp/blob/master/test/Unit/Task/PhpStanTest.php#L192
@veewee Can you check if I have added the correct unit test?
@dhaarbrink Thank you!
This adds a check on the 'use_grumphp_paths' config before skipping so this task runs even though there are no changed files when
use_grumphp_paths
is set to false.New Task Checklist:
run()
method readable?run()
method using the configuration correctly?