search

phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 430 forks source link

Allow PHP8 #844

Closed T2L closed 3 years ago

T2L commented 3 years ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? ?
Deprecations? ?
Documented? no
Fixed tickets #843

This PR adds support of PHP8 which going to be released 26/11/2020

T2L commented 3 years ago

So, seems like this PR makes the project PHP 8 compatible.

However, I think it's worth to wait for https://github.com/paratestphp/paratest/pull/559 to be committed as well as the new release (and avoid dev-master dependency)

veewee commented 3 years ago

Looks nice, thanks! We'll wait for paratest or until PHP 8 gets released - whichever comes first :)

T2L commented 3 years ago

Thanks :)

Btw, there is a new release of https://github.com/paratestphp/paratest/releases/tag/v6.0.0

veewee commented 3 years ago

Awesome! Checked this morning and it wasnt there yet. Will release PHP8 compatible version today as well ;)