search

phpro / grumphp

A PHP code-quality tool
MIT License
4.14k stars 430 forks source link

Catch ExecutableNotFoundException #855

Closed prudloff-insite closed 3 years ago

prudloff-insite commented 3 years ago
Q A
Branch master for features and deprecations
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets

Right now, only CommandNotFoundException is caught but ProcessBuilder::createArgumentsForCommand() can throw ExecutableNotFoundException.

This means that if phpcbf is not available, it will fail with only:

The executable for "phpcfbf" could not be found.

Instead of showing the errors + suggesting to install phpcbf.

veewee commented 3 years ago

That's much better indeed! Thanks for the PR!