Closed dshafik closed 3 years ago
If stop_on_failure is set to true, and a task has blocking set to false, GrumPHP will still stop execution rather than ignoring the failure as is done when stop_one_failure: false.
stop_on_failure
true
blocking
false
stop_one_failure: false
My configuration
grumphp: stop_on_failure: true tasks: phpstan: metadata: blocking: false use_grumphp_paths: false configuration: phpstan.neon.dist
Steps to reproduce:
Call ./vendor/bin/grumphp run with one task that will fail set to blocking: false (e.g. set process_timeout: 1 and put a sleep(2) in a phpunit test.
./vendor/bin/grumphp run
blocking: false
process_timeout: 1
sleep(2)
Result:
As you can see, phpstan has an orange x indicating it failed but should be ignored, and then GrumPHP Aborted…
phpstan
x
Aborted…
Thanks for reporting. Provided a PR that fixes this issue in #862.
If
stop_on_failure
is set totrue
, and a task hasblocking
set tofalse
, GrumPHP will still stop execution rather than ignoring the failure as is done whenstop_one_failure: false
.My configuration
Steps to reproduce:
Call
./vendor/bin/grumphp run
with one task that will fail set toblocking: false
(e.g. setprocess_timeout: 1
and put asleep(2)
in a phpunit test.Result:
As you can see,
phpstan
has an orangex
indicating it failed but should be ignored, and then GrumPHPAborted…