search

phpro / grumphp

A PHP code-quality tool
MIT License
4.13k stars 430 forks source link

All security checkers you ever needed #873

Closed veewee closed 3 years ago

veewee commented 3 years ago
Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #865, #870, #871

This PR adds support for 3 new security checkers in a BC safe way:

veewee commented 3 years ago

@paras-malhotra / @JeppeKnockaert / : I provided an alternative solution. Can you take a look at this approach? Thanks!

I'll give it a second review tomorrow, since I'm looking at the screen for a long time now :)

paras-malhotra commented 3 years ago

Looking great @veewee! 👍

Gotta admit the title of this PR is humorous 😄

cerw commented 3 years ago

Please merge, we need it :) thanks

veewee commented 3 years ago

It's coming up today @cerw ... Give me some time. Thanks for the patience!

cerw commented 3 years ago

@veewee Amazing! thanks