search

phpro / grumphp

A PHP code-quality tool
MIT License
4.13k stars 430 forks source link

Fix suffix property for PhpCpd v6 #905

Closed plopesc closed 3 years ago

plopesc commented 3 years ago
Q A
Branch master for features and deprecations
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

In PhpCpd 6.0.0 there're few changes in CLI options: https://github.com/sebastianbergmann/phpcpd/blob/master/ChangeLog.md#600---2020-08-13 which make GrumPHP failing.

However, in current implementation, the suffix argument is passed in this way: --suffix=*.php,*.myextension PhpCpd is expecting this argument in this format: --suffix=.php --suffix=.myextension

This PR Updates the way this argument is passed to the PhpCpd command.

Regards

veewee commented 3 years ago

Looks good! Thanks for the effort!