phpro / grumphp

A PHP code-quality tool

MIT License

4.13k stars 430 forks source link

Add security-checker using roave/security-advisories #914

Closed Zombaya closed 3 years ago

Zombaya commented 3 years ago

Q	A
Branch	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Documented?	yes
Fixed tickets

Contrary to what # #873 stated, I needed one more security checker!

The new security-checker allows projects already using roave/security-advisories to do a security-check using grumphp.

New Task Checklist:

[x] Are the dependencies added to the composer.json suggestions?
[x] Is the doc/tasks.md file updated?
[x] Are the task parameters documented?
[x] Is the task registered in the tasks.yml file?
[x] Does the task contains phpunit tests?
[x] Is the configuration having logical allowed types?
[ ] Does the task run in the correct context?
[ ] Is the run() method readable?
[ ] Is the run() method using the configuration correctly?
[ ] Are all CI services returning green?

veewee commented 3 years ago

Thanks for the PR!

Zombaya commented 3 years ago

Thanks for including it. Looking forward to being able to use it :slightly_smiling_face: