search

phpro / grumphp

A PHP code-quality tool
MIT License
4.13k stars 430 forks source link

Add subject pattern configurable option #916

Closed antode closed 3 years ago

antode commented 3 years ago
Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

I work in a Russian-speaking team and type/scope checks fails when the subject is written in only Russian. it would be great if we can define type_scope_conventions.subject_pattern like:

type_scope_conventions:
  - types: []
  - scopes: ~
  - subject_pattern: >-
      ([a-zA-Zа-яА-Я0-9-_ #@'\/\"]+)
veewee commented 3 years ago

Nice addition, thanks!