phpro / grumphp

A PHP code-quality tool
MIT License
4.12k stars 430 forks source link

replace opis/closure with laravel/serializable-closure #982

Closed ctrl-f5 closed 2 years ago

ctrl-f5 commented 2 years ago
Q A
Branch master for features and deprecations
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no

replace opis/closure with laralvel/serialzable-closure to support php 8.1

partially solves https://github.com/phpro/grumphp/issues/957

New Task Checklist:

ctrl-f5 commented 2 years ago

This issue was preventing us from moving to php8.1, but now we've also started seeing issues with grumphp on 8.0. (the same issue as in the checks in this MR.)

We have decided to just stop using grumphp on all our projects and packages and move the functionality to our make workflow, which already handled all other automations.

As a result I will not be putting any more effort in this MR.

veewee commented 2 years ago

Sad to hear @ctrl-f5! Especially since it is all caused by dependencies and is pretty much out of our control :)

Anyways, Good luck with your projects and packages!